Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pie install php/gdcurrently fails during package resolution because GD is excluded from the bundled-extension repository. This registersphp/gdand exposes optional--with-jpegand--with-freetypeflags, so users can build GD with the image capabilities they need.The existing build-provider refusal and
--forceoverride remain unchanged. JPEG and FreeType remain opt-in; their development libraries must be installed. The package requires PHP 7.4+ because that is when these configure flag names were introduced.The change adds package/option unit coverage and a CI build test across the existing PHP 8.1–8.5 bundled-extension matrix. The build test installs the default package and then rebuilds the same version with both flags, checking PNG/JPEG encode/decode and actual FreeType text rendering in fresh PHP processes.
Validation
--forcestill refuses the bundled extension in the official PHP Docker image.The historical
ft2build.hfailure recorded in the original GD review thread was not reproduced in these environments. This PR does not claim to establish its original cause; the added build/feature tests are intended to make the proposed support verifiable.Discussion status
Discussion #781 was opened before implementation. Maintainer feedback is still pending; this PR is a draft for review, and the discussion checklist item below remains unchecked.
PR submitter checklist