Repository navigation
Conversation
added 2 commits
October 23, 2026 12:29
Parse the column options AS ROW START, AS ROW END and WITH/WITHOUT SYSTEM VERSIONING, the PERIOD FOR SYSTEM_TIME definition and the WITH SYSTEM VERSIONING table option. They are available since MariaDB 10.3.4. Fixes phpmyadmin#235 Signed-off-by: Магда М.Г. <mail@mgmagda.ru>
SHOW CREATE TABLE prints SEQUENCE=1 for sequence tables since MariaDB 10.3. The option was silently dropped. Signed-off-by: Магда М.Г. <mail@mgmagda.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #235
SHOW CREATE TABLEof a system-versioned table (MariaDB 10.3.4+) could not be parsed. Checked with MariaDB 11.8:Before (context
MariaDb110800):and
build()returned the table cut after`row_start` timestamp(6) GENERATED ALWAYS AS ROW. After: no errors, and the statement is built back with all columns, the period and the table option.Changes:
AS ROW START,AS ROW END,WITH SYSTEM VERSIONING,WITHOUT SYSTEM VERSIONINGandPERIOD FOR SYSTEM_TIME(K) added to the MariaDB 10.3+ files intools/contexts, contexts regenerated withtools/ContextGenerator.php. MySQL contexts are not changed.AS ROW START,AS ROW END,WITH SYSTEM VERSIONING,WITHOUT SYSTEM VERSIONING; table optionWITH SYSTEM VERSIONING.SEQUENCE. MariaDB prints) ENGINE=InnoDB SEQUENCE=1for a sequence, and the option was silently dropped from the built statement.Docs:
Tests: parser fixtures
parseCreateTableSystemVersioning_mariadb_100300,parseCreateTableSystemVersioning2_mariadb_100300(columnWITHOUT SYSTEM VERSIONING),parseCreateTableSequence_mariadb_100300, and two round-trip tests intests/Builder/CreateStatementTest.php.