Skip to content

Improve pcov e2e tests #6770

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
staabm merged 1 commit into from
Oct 21, 2026
+24 −9
Merged

Improve pcov e2e tests #6770

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions .github/workflows/e2e-tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,20 +2036,20 @@ jobs:
../bashunit assert contains 'Bar.php:15:Call to an undefined method Ds\Pair<string, int>::copy().' "$OUTPUT"
../bashunit assert not_contains 'Ds\Seq' "$OUTPUT"
- script: |
echo "<?php echo 'Hello 1';" > test.php
XDEBUG_HANDLER_DEBUG=1 bin/phpstan analyse test.php 2>&1 | tee -a output.txt
e2e/bashunit assert file_contains output.txt "Process restarting"
cd e2e/bug-15407
XDEBUG_HANDLER_DEBUG=1 ../../bin/phpstan analyse --no-progress 2>&1 | tee -a output.txt
../bashunit assert file_contains output.txt "Process restarting"
coverage: "pcov"
- script: |
echo "<?php echo 'Hello 2';" > test.php
XDEBUG_HANDLER_DEBUG=1 bin/phpstan analyse test.php 2>&1 | tee -a output.txt
e2e/bashunit assert file_contains output.txt "Process restarting"
cd e2e/bug-15407
XDEBUG_HANDLER_DEBUG=1 ../../bin/phpstan analyse --no-progress 2>&1 | tee -a output.txt
../bashunit assert file_contains output.txt "Process restarting"
coverage: "pcov"
ini-values: "pcov.enabled=1"
- script: |
echo "<?php echo 'Hello 3';" > test.php
XDEBUG_HANDLER_DEBUG=1 bin/phpstan analyse test.php 2>&1 | tee -a output.txt
e2e/bashunit assert file_not_contains output.txt "Process restarting"
cd e2e/bug-15407
XDEBUG_HANDLER_DEBUG=1 ../../bin/phpstan analyse --no-progress 2>&1 | tee -a output.txt
../bashunit assert file_not_contains output.txt "Process restarting"
coverage: "pcov"
ini-values: "pcov.enabled=0"

Expand Down
6 changes: 6 additions & 0 deletions e2e/bug-15407/pcov-check.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
<?php declare(strict_types = 1);

if (extension_loaded("pcov")) {
fwrite(STDERR, "pcov is still loaded after the restart\n");
exit(1);
}
6 changes: 6 additions & 0 deletions e2e/bug-15407/phpstan.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
parameters:
level: 0
paths:
- test.php
bootstrapFiles:
- pcov-check.php
3 changes: 3 additions & 0 deletions e2e/bug-15407/test.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
<?php

echo 'Hello';
Loading