Repository navigation
Keep buffered rows when a database dump chunk is flushed - #1482
Open
RaphaelFakhri wants to merge 1 commit into
Open
RaphaelFakhri wants to merge 1 commit into
RaphaelFakhri wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pscale database dumpwith SQL output can silently drop the last rows of a table.The SQL writer groups rows into an
INSERTstatement everyStmtSizebytes and writes a chunk file everyChunksizeInMB.Flushwrote only the completedINSERTstatements and reset the chunk byte counter, leaving the remaining buffered rows for the next file. When the table ended right after that flush,Closesaw a chunk byte count of 0 and returned without writing those rows. With the default settings, up to about 1 MB of rows at the end of a table could be missing from the dump without an error.Changes
Flushnow turns the buffered rows into a finalINSERTstatement before it writes the chunk file, so each file is complete and no rows are carried over.INSERTconstruction moves into a smallappendInserthelper thatWriteRowandFlushshare;Closeno longer needs its own copy.TestDumperKeepsRowsAtChunkBoundary, which dumps a table where the last row reaches the chunk size without completing anINSERT, and checks that every row is in the output files.Testing
got: int(1040),want: int(1043).go test ./internal/dumper/ ./internal/cmd/database/passes, andgolangci-lint run ./internal/dumper/...reports 0 issues.Fixes #1481