[tsmr]

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

Permit to Inject GlpiAsset (and add Injectable Capacity)
Warning this development don't add type & model injection of GlpiAsset

[Herafia]

Hello @tsmr,
You can use these commands to resolve the CI issue:
../../vendor/bin/phpstan
../../vendor/bin/php-cs-fixer fix
../../vendor/bin/rector
php bin/console tools:licence_headers_check

Thank you!
Laura - Teclib

[Mirkk]

Hi all! Thank you for this great PR! We tested it and it seems to work well:

• import of basic data works
• import of standard dropdowns works
• import of OS, Port, IP (NetworkName) works

We're happy it works now, and of course don't pretend that it is be perfect, however we have some feedback, in order of importance:

1. Type and Model Dropdowns not shown to be imported
2. "Comment" is not shown to be imported (often very important in CSV imports)
3. Custom Dropdowns are not shown to be imported
4. (minor as it seems a generic problem in the last versions): with port unicity criteria set to "name" still an new IP (networkname) for the same name is added, not replaced)

Thank you!

[RomainLvr]

Re Mirkk's feedback (point 3, custom dropdowns): custom fields use search option ids >= 45000 (CustomFieldDefinition::getSearchOptionID()), but PluginDatainjectionCommonInjectionLib::addToSearchOptions() only flags ids < 1000 as injectable, so they're dropped before the blacklist logic even runs. Even after lifting that, every custom field shares the same linkfield (custom_fields, since values are stored in one JSON column), and addToSearchOptions() keeps only one option per linkfield (dedup added for issue #121) - so only one custom field could ever be importable at a time, and writing a resolved value back would need to target custom_<system_name> rather than custom_fields directly (see Asset::handleCustomFieldsUpdate()). That's bigger than a one-line fix, flagging it so it's tracked rather than silently missing.

[RomainLvr]

Removing these two lines drops the Type (4) and Model (40) dropdown options entirely, so they can never be imported. They come from Asset::rawSearchOptions() and behave like any other dropdown option already supported here (e.g. Manufacturer, 23).

Suggested change

	unset($tab[4]);
	unset($tab[40]);

[tsmr]

As say into the PR : Warning this development don't add type & model injection of GlpiAsset ? So you can continue the development if you want

[Herafia]

Hello @tsmr,

Thanks for these latest updates.
I've included a few small suggestions.

If you'd like, you can also check the “Allow changes by maintainers” box on this PR. That would allow us to push small fixes directly to your branch and speed up the merge.

Thanks!

[tsmr]

Hello @tsmr,

Thanks for these latest updates. I've included a few small suggestions.

If you'd like, you can also check the “Allow changes by maintainers” box on this PR. That would allow us to push small fixes directly to your branch and speed up the merge.

Thanks!

I can't :/ My branch is on our organization's server. But I can give you temporary write access to my branch