[Rom1-B]

Checklist before requesting a review

Please delete options that are not relevant.

• I have performed a self-review of my code.
• I have added tests (when available) that prove my fix is effective or that my feature works.
• I have updated the CHANGELOG with a short functional description of the fix or new feature.
• This change requires a documentation update.

Description

• It fixes !45901
• When a container's computed table name exceeds MySQL's 64-character limit, the plugin now disables it instead of crashing, and shows a rename form directly on the container's edit page.
• Submitting a shorter name renames the container and reactivates it; if a table with matching data already exists under that name (e.g. after a version migration), its data is preserved instead of being replaced by an empty table.
• plugins:fields:check_database now also reports container/item type pairs with no matching table, and tables with no matching container/item type pair.

Screenshots (if appropriate):

[stonebuzz]

@Rom1-B can you rebase ?

[stonebuzz]

CI failed

[MyvTsv]

I think the user should not be able to reactivate a container that has been inactive for too long, in order to avoid potential errors caused by its reactivation.

[stonebuzz]

PluginFieldsToolbox::getSystemNameFromLabel() never returns an empty string: for an empty or non-alphanumeric label it falls back to random_int() converted to letters. Submitting the rename form with a blank field therefore renames the container to a random string and reactivates it, and this guard is dead code. Validate the raw input before transforming it.

    if (trim($new_name) === '') {
        Session::AddMessageAfterRedirect(__('Invalid name.', 'fields'), false, ERROR);
        return false;
    }
    $new_name = $toolbox->getSystemNameFromLabel($new_name);