Skip to content

Fix NotImplementedError in cache with non-standard nodeids in lastfailed - #107

Open
Fire162 wants to merge 1 commit into
pytest-dev:mainfrom
Fire162:fix-failed-first-not-implemented
Open

Fire162 wants to merge 1 commit into
pytest-dev:mainfrom
Fire162:fix-failed-first-not-implemented

Conversation

@Fire162

@Fire162 Fire162 commented Oct 24, 2026

Copy link
Copy Markdown

Pytest's cache/lastfailed can contain keys that do not split into 2 or 3 parts (such as file or directory paths recorded on collection errors, or deeply nested test items).

The parsed last_failed list was unused, while the NotImplementedError raised on unrecognized key shapes aborted test runs when --failed-first was active. Removing the unused loop lets the nodeid lookup continue without failing.

Fixes #41, fixes #53.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in --failed-first? process_failed_first_last_failed → NotImplementedError

1 participant