Repository navigation
Conversation
Reserve four bytes in the initial frame and keep full-size CONTINUATION fragments. Add boundary and peer round-trip regressions. AI disclosure: discovered, implemented, tested, and independently AI-reviewed by Codex AI agents at the account owner request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Large pushed request headers can make
H2Connection.push_stream()raiseAssertionErroreven when the header list is below the peer's limit._build_headers_frames()gives the first PUSH_PROMISE a full frame's worth of HPACK data, then serialization adds the four-byte promised stream ID, exceedingSETTINGS_MAX_FRAME_SIZE. With assertions disabled, the oversized frame reaches the peer and is rejected instead.Reserve those four bytes in the first fragment, while allowing each CONTINUATION to use the full frame payload. This follows RFC 9113 sections 4.2 and 6.6.
The regression uses two h2 peers with the default 16,384-byte limit. Six cases cover small headers, the first-fragment boundary, a one-byte overflow, the full-frame boundary, and multiple continuations. It checks serialized frame sizes, stream IDs, END_HEADERS placement, HPACK byte preservation, and the receiving client's PushedStreamReceived event.
Validation on macOS, CPython 3.13.12:
python -bb -m pytest --cov=h2 --cov-report=term --cov-report=xml).ruff check src/ tests/test_push_promise_fragmentation.pyandmypy --strict-bytes src/ tests/typing/strict_bytes.pypass.AI assistance was used to prepare the implementation and regression tests.