Repository navigation
Conversation
FanWu-ai
marked this pull request as ready for review
October 19, 2026 22:05
Merging this PR will not alter performanceℹ️ 1 benchmark has no flame graph
Comparing |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
freeze=Trueflag is ignored bytravel()andtravel_to()once a ticking trip has already started. For example:_start()returns immediately for an active traveller, so itsfreezeargument never reaches time-machine. Passtick=Falsetomove_to()when freezing is requested. Otherwise passNoneto retain the current ticking/frozen state, preserving the existingfreeze(); travel(...)behavior.Add 16 deterministic regression/control cases covering fresh, ticking and frozen travellers, both travel methods, repeated moves, restarting after
travel_back(), chaining and nested independent traveller contexts. The new tests advance time-machine's real-clock source explicitly rather than waiting for wall-clock time. Document that freezing also applies to an active trip and that subsequent moves retain the frozen state.Validation on Linux x86_64 / CPython 3.12.14:
PENDULUM_EXTENSIONS=0.mypy: passed over 228 source files.prek run --all-files: all six hooks passed, including Rust formatting and clippy.mkdocs build --strict -f docs/mkdocs.yml: passed with six existing informational anchor notices.twine check --strictpassed. All 122 production Python files in both artifacts match the tested checkout byte-for-byte.The three existing skips cover one Windows-only test and two unsupported POSIX transition cases. Existing checks and their configuration are unchanged. Other Python versions and operating systems have not been tested locally; hosted CI is not claimed passed.
Prepared and tested with OpenAI Codex assistance, including automated review. No human review is claimed.
Pull Request Check List