Repository navigation
Fix CI installation of the stub package - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Python 3.10 CI job fails during editable installation when the isolated setuptools backend invokes pip and reports "No module named pip". PowerShell continues to the package-listing command, masking the failed installation. Tests then run without this repository's patched stubs and report 26 mypy failures.
Observed failure: https://github.com/python-qt-tools/PySide2-stubs/actions/runs/39974454642/job/120485313967
Use regular package installation instead of editable installation, and remove the pip downgrade that was required only for the legacy editable path. Explicitly declare both stub packages so older setuptools versions used with Python 3.6 include the stub files in the wheel. Run dependency installation under Bash so a failing command immediately fails the step. Preserve the existing Python/mypy matrix and test commands.
Validation: Both Windows CI jobs pass: Python 3.6 with mypy 0.940 and Python 3.10 with mypy 0.971. Reproduced a wheel containing zero stub files with setuptools 59.6.0, then confirmed the explicit package list produces and installs all 50 stub files. All 78 tests passed locally on Linux with Python 3.10 and mypy 0.971 using both the initial modern-backend install and the corrected legacy-backend wheel. Workflow linting has no new findings; the existing checkout/setup-python v3 action-version warnings are unchanged. Whitespace checks passed.
This PR targets main independently of the optional compatibility extra in #9.