Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the existing channel normalization in
write_png, including the normalization of the alpha channel and ofuint8RGB input after an alpha channel is added. Show how callers can preserve RGB colors by preparing auint8RGBA array.Also replace the Python 2 base64 example with an executable Python 3 example and add focused pixel-level tests for the documented behavior. The test helper uses only the standard library to decode the generated PNG scanlines.
This is a documentation and test contribution related to #195. It does not change normalization behavior, add an option, or resolve the request to change that behavior.
Verification
python -m pytest -vv -rxs tests -m 'not headless': 39 passed, 2 deselected.write_pngdocstring execute successfully._staticdirectory warning.git diff --checkpass.Prepared with AI assistance. The documentation, decoded pixel results, examples, and local checks were reviewed; no claim of maintainer endorsement is intended.