Skip to content

Skip layer invalidation when an iOS View only changes position #59168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hryhoriiK97 wants to merge 1 commit into
base: main
Choose a base branch
from
+9 −1
Open

Skip layer invalidation when an iOS View only changes position #59168

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion packages/react-native/React/Fabric/Mounting/ComponentViews/View/RCTViewComponentView.mm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -700,8 +700,16 @@ - (void)updateLayoutMetrics:(const LayoutMetrics &)layoutMetrics
// the oldLayoutMetrics parameter (which comes from the shadow tree).
auto previousFrameSize = _layoutMetrics.frame.size;

// A relayout that only moves the view leaves everything `invalidateLayer`
// derives unchanged, since it works in the view's own coordinates. The hover
// shape is the exception: iOS evaluates it in the superview's space.
auto movedLayoutMetrics = layoutMetrics;
movedLayoutMetrics.frame.origin = _layoutMetrics.frame.origin;
BOOL const onlyMoved = movedLayoutMetrics == _layoutMetrics;
_layoutMetrics = layoutMetrics;
_needsInvalidateLayer = YES;
if (!onlyMoved || _props->cursor == Cursor::Pointer) {
_needsInvalidateLayer = YES;
}

_borderLayer.frame = self.layer.bounds;

Expand Down
Loading