Repository navigation
Label Reflex compiler and server processes by role - #7655
Akarshkushwaha wants to merge 2 commits into
Conversation
[Low impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found. SummaryLabels compiler and Granian server processes by role so they are easier to identify in process listings.
Reviews (2) · Last reviewed commit: "Address process title review feedback" · Reviewed by Greptile |
There was a problem hiding this comment.
1 issue found across 10 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="reflex/utils/exec.py">
<violation number="1" location="reflex/utils/exec.py:485">
P2: The frontend title is only passed in the Granian branch; the Uvicorn fallback starts a plain `gunicorn`/`uvicorn` command, so standalone frontend processes remain unlabeled when that fallback is selected. Apply the frontend role title to the fallback too.</violation>
</file>
Reply with feedback, questions, or to request a fix.
View guided diff | Re-trigger cubic
| port, | ||
| loglevel, | ||
| app_target=f"{__name__}:_frontend_prod_app", | ||
| process_name=processes.get_process_title("frontend"), |
There was a problem hiding this comment.
P2: The frontend title is only passed in the Granian branch; the Uvicorn fallback starts a plain gunicorn/uvicorn command, so standalone frontend processes remain unlabeled when that fallback is selected. Apply the frontend role title to the fallback too.
Prompt for AI agents
Check if this issue is valid — if so, understand the root cause and fix it. When an issue isn't valid or won't be fixed in this PR, reply in its thread with the reason and then resolve the thread. At reflex/utils/exec.py, line 485:
<comment>The frontend title is only passed in the Granian branch; the Uvicorn fallback starts a plain `gunicorn`/`uvicorn` command, so standalone frontend processes remain unlabeled when that fallback is selected. Apply the frontend role title to the fallback too.</comment>
<file context>
@@ -472,11 +472,17 @@ def run_frontend_prod(host: str, port: int):
+ port,
+ loglevel,
+ app_target=f"{__name__}:_frontend_prod_app",
+ process_name=processes.get_process_title("frontend"),
)
else:
</file context>
Closes #7643.
Reflex child processes currently appear in process listings with repeated command lines or multiprocessing bootstrap arguments, making them difficult to tell apart.
This change labels the compiler, Granian backend, and standalone production frontend by role. For example,
psnow showsreflex run [compiler],reflex run [backend], andreflex run [backend] worker-1.It enables Granian's
pnameextra and builds titles independently ofsys.argvso they work with spawned processes. Regression tests, deployment documentation, and a changelog fragment are included.All Submissions:
Type of change
New Feature Submission:
Changes To Core Features:
Validation
Remaining validation limitations
The overall checkboxes above are left unchecked because these checks are not fully green locally:
test_reflex.py.reflex-components-corebecause of an import error, also reproduced on the unchanged baseline.macOS was not tested locally. Windows Task Manager command lines remain unchanged, as noted in the issue.