Repository navigation
Conversation
Author
|
I think the failing workflow is unrelated. I've tried to keep this PR as succinct and non-slop as possible. Tests added, happy to revise, let me know your thoughts. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Resolves #251.
Vim considers command-line mode a distinct primary mode, but
vim-mode-changewas not emitted when entering or exiting command-line prompts (:,/,?). Consumers had to track dialog state manually.What changed
vim-mode-changewith{ mode: "command" }when an interactive prompt opens.vim-mode-changewith the restored mode (normal,visual, orinsert) when the prompt closes or is cancelled via Escape.VimMode,VimSubMode, andVimModeChangeEventdiscriminated union types, replacinganyin the mode change listener.on_mode_changetest suite to assert command mode transitions.Test plan
pnpm run typecheckto verify strict TypeScript compilation.pnpm testto verify all 711 tests pass.on_mode_changepasses when entering command mode with:and exiting with bothy\nand<Esc>.