Repository navigation
Patch brotli for Node 24 on the cached nodejs pin - #505
Merged
Merged
Conversation
rahultee
approved these changes
Oct 22, 2026
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
#499 pinned Node 24 to a nixpkgs
stagingcommit (dc0146be), which Hydra doesn't build. That forced ~220 uncached rebuilds (perl, python3, openssl, ...) and the goval nixmodules disk image job timed out.What changed
Drop the
nixpkgs-node24input. Build Node 24.22.1 from the existingnixpkgs-nodejspin, with the same brotli CVE patch nixpkgs already applies to the other Node majors there. That patched brotli is the same derivation Node 22 uses, so it's already cached.Remove
brotli-patchedwhennixpkgs-nodejsis bumped past the upstream fix, or the patch will be applied twice.Test plan
nix build --dry-run .#nodejs-24 .#angular-node-24only buildsnodejs-slim-24.22.1,nodejs-24.22.1and the module wrappers.Rollout