Repository navigation
refactor: remove obsolete website code and check unused exports - #1443
Merged
fhammerschmidt merged 19 commits intoOct 20, 2026
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Remove local screenshot-update aliases and document the feature-branch CI workflow that owns visual baselines. Point the full-site Cypress suite at the Vite dev server, explain server startup and URL overrides, and distinguish the managed production homepage suite. Fixes rescript-lang#1415
Keep localhost as the full-site Cypress hostname while correcting the default port to 5173. Align the README default URL and alternate-port example with the config.
Remove abandoned scripts, compiler installations, components, and data. Keep live MDX mappings and framework entry points, trim unused interfaces, and enforce the monorepo dead-value check in CI. Fixes rescript-lang#1409
fhammerschmidt
force-pushed
the
fix/1421-dead-code
branch
from
October 11, 2026 22:24
3cd3497 to
a2bdd1f
Compare
Remove 42 redundant implementation annotations and document keeping @LiVe in interfaces when available. Retain 44 annotations, each verified necessary by removing it individually and rerunning the analyzer.
Document the workspace paths, docs SSR and guide deployment, current MDX pipeline, compiler sources, staged formatting hooks, and generated output policy. Clarify link-check working directories and CI behavior, recommend Oxc in VS Code, and ignore bundled Yarn releases by pattern. Refs rescript-lang#1417 and rescript-lang#1421.
Wait for the client router and a gallery state update before focusing the prerendered Get started link. This prevents a one-shot focus event from racing React hydration while preserving the no-prefetch, focus-prefetch, and blur-cleanup assertions.
Document separate docs and guide production builds and Vitest commands. Run Oxfmt and ReScript formatting from the monorepo root, with the docs alias delegating there, so all four workspaces are covered.
Keep focused docs helpers in their workspace and retain contributor commands with an explicit purpose. Document manual tools and Yarn preparation behavior, and remove duplicate docs formatting and cleaning entries.
Remove the unused root preparation alias also removed by rescript-lang#1419. Docs development still calls its workspace preparation script explicitly, and this keeps the contributor-docs and script-audit PRs compatible.
Remove the unused root homepage-performance alias also removed by rescript-lang#1419. CI still invokes the docs workspace command directly, and this avoids a conflict next to the dead-code check entry.
Include rescript-lang#1451 so its package-script audit can merge first without conflicts. Preserve the repository-wide root formatter and docs workspace formatting delegate.
Include rescript-lang#1451 so its package-script audit can merge first without conflicts. Preserve the dead-code check and corrected repository-wide reanalyze commands.
Keep the package-script audit focused on the eight redundant entries. Explain retained manual commands in the PR description without duplicating package scripts and contributor documentation.
Keep the package-script audit focused on the eight redundant entries. Explain retained manual commands in the PR description without duplicating package scripts and contributor documentation.
Scope interface and component export rules to route modules, document filename exceptions, and distinguish component tests from end-to-end routing checks. Correct Obj.magic and React Router binding examples, and point warning checks at yarn build:res.
Keep current route-generation commands alongside Cypress guidance and the CI screenshot workflow. Preserve localhost for the full-site Cypress suite.
jderochervlk
approved these changes
Oct 20, 2026
jderochervlk
left a comment
jderochervlk
left a comment
Collaborator
There was a problem hiding this comment.
PRs that delete code are my favorite PRs 🚀
Keep the monorepo commands and generated-output checks while documenting CI-owned screenshot updates and the supported Cypress dev-server URL. Preserve the removal of local snapshot-update aliases.
Preserve the current workspace commands, formatting exclusions, and CI-owned screenshot workflow. Keep the approved corrections to ReScript interop examples, route interfaces, module names, and component testing rules.
Preserve current routing, CI checks, documentation, and tests while removing obsolete code. Retain guide reset helpers and text-content assertions now used by newer tests, mark new framework loader exports live, and remove route builders superseded by the shared route table.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove obsolete compiler installations, CodeMirror 5 setup, scripts, shims, duplicate MDX components, the unused scroll-lock context and
stdlib-toc.json.Remove unused helpers, interface exports and model fields, plus four unused direct dependencies and their lockfile entries.
Add
yarn check:dead-codeand make unused ReScript values and exports fail CI across all workspaces. Keep record-field and argument diagnostics advisory. Put necessary@liveannotations on interfaces or standalone entrypoints, with each entrypoint annotated once.Make the homepage CSS prefetch test wait for hydration before focusing its link.
Merge last among the open #1421 PRs, including after #1451. Refresh the cleanup as the other changes land.
Part of #1421.
Fixes #1409