Repository navigation
feat: add v13 preview to documentation version selector - #1460
Open
fhammerschmidt wants to merge 2 commits into
Open
fhammerschmidt wants to merge 2 commits into
fhammerschmidt wants to merge 2 commits into
Conversation
Expose the v13 preview from the stable documentation selector and keep the current preview out of its own alternatives. Extend the ReScript dropdown test to check visibility and the destination URL.
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Build the preview link from React Router's current path, query, and fragment using the fixed v13 origin. Render selector tests within MemoryRouter and cover manual and API page navigation.
fhammerschmidt
added
the
ok-to-deploy
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stable documentation version selector exposes only older releases, so readers cannot discover the v13 preview.
Add v13 (preview) while keeping v12 as the current/latest documentation. Build its URL from the fixed
https://v13.rescript-lang.orgorigin and React Router's current path, query, and fragment. For example, switching from/docs/manual/array-and-list#immutable-listsopens that page and anchor on the v13 site. Omit the preview alternative when the current docs version is already v13.Keep the existing older-version destinations. Extend the ReScript browser tests to cover dropdown visibility, the destination host, manual/API page preservation, and query/anchor preservation. Selector tests use MemoryRouter, matching the router context used by the app.
Two files changed: +66 / −12 lines. #1458 handles the v13 site's preview label and link back to released v12 documentation; this PR supplies the stable site's missing entry.
Validation: strict ReScript compilation, formatting, route-generation check, and unused-export checks pass locally. The preview destination responds successfully. Updated browser tests and the remaining checks run in CI.