Repository navigation
perf(fmt): reuse formatter import promise - #589
Merged
Merged
Conversation
Deploying rstack-cli with
|
| Latest commit: |
459fa4c
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://904d0157.rstack-cli.pages.dev |
| Branch Preview URL: | https://chenjiahan-cache-fmt-import.rstack-cli.pages.dev |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Formatting each uncached file repeats a dynamic
import()call even after the formatter module has loaded.Changes
Add a
cachedImporthelper following Rsbuild: share pending and fulfilled imports, and clear rejected Promises to allow retries. Use it in the formatter worker while keeping imports after cache-hit checks so formatter dependencies still load lazily.Prior prototype profiling reduced cumulative repeat-import time across 8 workers from 829 ms to 49 ms. Whole-repository check medians were 16.61 s before and 16.64 s after (7 fresh-process runs, Node.js 22.16.0,
--no-cache), so no stable end-to-end speedup was observed. These measurements predate the helper extraction.Validated package and native builds, 156 focused tests (including lazy loading, import reuse, and retry after rejection), lint, type checking, and formatting.