Repository navigation
Conversation
Markdown link reference labels are case-insensitive, but the parser stored and looked up references by their exact text, so [Foo][] or [ID] did not resolve against a [foo]: or [id]: definition and were left as literal brackets in the output.
Documentation previewCommit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Markdown link reference labels are matched case-insensitively (both in the original Markdown syntax and in CommonMark), but
RDoc::Markdownstored and looked up references by their exact text. So withboth links were left as literal
[the Docs][]and[Ruby]in the output.The label text is already normalized for whitespace in the
Labelrule, so I added a smallreference_keyhelper that downcases the label, and used it both where a reference is stored and where a link looks it up. The link text keeps its original case.I changed
markdown.kpegand regeneratedmarkdown.rbwithrake generate;rake verify_generated,rake normal_testandrubocoppass locally.