Repository navigation
test(network): wait for network idle before checking a failed XHR's error - #678
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
`Network::Response#error captures errors` failed on main (run).
The page fires an XHR to `/unexist.png` and its `complete` callback changes the heading to "Done". An XHR doesn't delay the load event, so `go_to` can return while the request is still pending. The CDP log from the failed run shows exactly that: `frameStoppedLoading` came 4 ms after the XHR started, `at_xpath` returned `null`, and only then did the 404 headers arrive.
The spec now waits for the network to go idle and asserts on the exchange error directly. The "Done" heading check was only there to sync on the request, and it still raced with the JS callback, so it's removed.