Skip to content

ci, test: pin ubuntu-24.04, prevent apt download stalls, and stabilize test timeouts - #5245

Merged
polybassa merged 4 commits into
secdev:masterfrom
BenGardiner:ci-pin-ubuntu-2404
Oct 23, 2026
Merged

polybassa merged 4 commits into
secdev:masterfrom
BenGardiner:ci-pin-ubuntu-2404

Conversation

@BenGardiner

@BenGardiner BenGardiner commented Oct 22, 2026 •

Copy link
Copy Markdown
Contributor

GitHub Actions migrated ubuntu-latest to Ubuntu 26.04. On Ubuntu 26.04, actions/setup-python does not provide Python 3.8 and 3.9, and OpenSSL 3.4 disallows legacy TLS 1.0 and 1.1 handshakes in test_tls_server.

Pin ubuntu-24.04 in .github/workflows/unittests.yml for the utscapy matrix, replace azure.archive.ubuntu.com mirrors with archive.ubuntu.com and timeout linux-modules-extra in .config/ci/install.sh to prevent package download stalls, and increase timeout in test/contrib/automotive/testsocket.uts to prevent test runner timeouts on Windows.

This message was written with the help of AI (GPT-5.6-Cyber).

@codecov

codecov Bot commented Oct 22, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 60.60606% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.17%. Comparing base (49b0361) to head (fc03a57).

Files with missing lines Patch % Lines
scapy/as_resolvers.py 60.60% 13 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5245      +/-   ##
==========================================
+ Coverage   80.82%   81.17%   +0.35%     
==========================================
  Files         394      394              
  Lines       98758    98770      +12     
==========================================
+ Hits        79822    80181     +359     
+ Misses      18936    18589     -347     
Files with missing lines Coverage Δ
scapy/as_resolvers.py 77.77% <60.60%> (-6.99%) ⬇️

... and 21 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

GitHub Actions updated ubuntu-latest to Ubuntu 26.04. On Ubuntu 26.04,
actions/setup-python does not provide Python 3.8 and 3.9, and OpenSSL 3.4
disallows TLS 1.0 and 1.1 handshakes in test_tls_server. Pin ubuntu-24.04
for the utscapy test matrix to maintain test compatibility across Python
versions and legacy TLS tests.

Also replace degraded azure apt mirrors with archive.ubuntu.com, set apt
timeouts, and increase runner timeout to 30 minutes to prevent apt download
stalls from exhausting the test timeout.

AI-Assisted: yes (GPT-5.6-Cyber)
In test/contrib/automotive/testsocket.uts:50, sender.sr1() used a 0.5s
timeout to receive paired responses across 1000 loop iterations. On loaded
Windows CI runners, thread scheduling jitter can exceed 0.5s, causing sr1()
to return None and pks.sr() to raise AttributeError. Increase timeout to 1s.

AI-Assisted: yes (GPT-5.6-Cyber)
@BenGardiner BenGardiner changed the title ci: pin ubuntu-24.04 and prevent apt download stalls in utscapy ci, test: pin ubuntu-24.04, prevent apt download stalls, and stabilize test timeouts Oct 23, 2026
In .github/workflows/unittests.yml:103, run jobs using matrix.runner while
keeping matrix.os as ubuntu-latest so that job names match the required
status check contexts in master branch protection.

AI-Assisted: yes (GPT-5.6-Cyber)
…nsive whois servers

In scapy/as_resolvers.py, add a default 5-second socket timeout to
AS_resolver and AS_resolver_cymru so that unresponsive or rate-limiting
whois servers (such as whois.ra.net) fail fast and allow AS_resolver_multi
to fall back to subsequent resolvers.

AI-Assisted: yes (GPT-5.6-Cyber)
@polybassa

Copy link
Copy Markdown
Contributor

Thanks for the PR

@polybassa
polybassa merged commit bf1b540 into secdev:master Oct 23, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants