Repository navigation
UTCTimeField: do not fail on out of range timestamps - #5247
Open
bacescuandrei wants to merge 1 commit into
Open
bacescuandrei wants to merge 1 commit into
bacescuandrei wants to merge 1 commit into
Conversation
i2repr() raised OverflowError for values that datetime cannot represent, e.g. a NTLMv2_CLIENT_CHALLENGE TimeStamp of 0xffffffffffffffff, which made show() and sprintf() fail. AI-Assisted: yes (Claude Code, claude-opus-5-5)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
UTCTimeField.i2repr()raisesOverflowError: date value out of rangewhen the timestamp is outside of the yearsdatetimesupports, soshow()andsprintf()fail on such packets:With this change,
i2repr()returns the number of seconds alone for these values, as it does after the date for other values.