Repository navigation
Add Tx.NamedQueryContext (upstream #724). - #21
Merged
Merged
Conversation
This change adds the NamedQueryContext method on Transactions to match calls on the Database directly. This allows the use of `DB` and `Tx` objects more interchangeably in consuming codebases.
…rom upstream #941) and guard the promoted Stmt methods.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merges upstream jmoiron/sqlx#724 by Dave Worth with its original commit:
Tx.NamedQueryContext, the context twin ofTx.NamedQuery, with its test inTestUsageContext. Closes upstream #447 (39 reactions; duplicates #348, #373, #565, #941).A follow-up commit takes the two
qStmtmethods from #941 by Jon Senchyna,QueryRowandQueryRowContext, on the unexported prepared-statement queryer where they belong. #941 itself is not merged: it putQueryRowContexton*Stmt, which shadows the promoted(*sql.Stmt).QueryRowContextand silently drops the first argument, and it widenedQueryerandQueryerContext, a compile break for every external implementor. The interfaces stay unchanged here; a guard test keeps the promoted methods working.Local run with Postgres 16, MySQL 8.4 and SQLite: 88 pass, 3 skip, 0 fail.