Repository navigation
Conversation
sogs-ban now lists every id before the confirmation prompt, and in a dry run, with the display name from its newest post in each room's last 256 messages: "posted as 'X'", "posted, with no display name" or "no recent posts". A room that cannot be read is named under the list. Claude-Session: https://claude.ai/code/session_019cnvrsCXsqLykDyQburD2f
Collaborator
Author
|
Folded into #76 so the three changes can be iterated on together. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sogs-banaskedContinue? [y/N]without showing who the ids belonged to, so a moderator could not check a ticket's ids against the accounts before banning them.Before the prompt, and in a dry run, each id is now listed with the display name from its newest post:
names.pyreads each room's last 256 messages (the most/messages/recentreturns), matches them by either blinded form of the id, and decodes the display name from the message's protobuf. On our three rooms that is currently their whole history.200is named under the list, so its posters do not read as "no recent posts".GETs, and runs before anything is sent.Tested with
tests/sogs/test_names.py(decoding padded and unpadded content, newest post wins, deleted posts skipped, unreadable rooms reported) and with a live dry run against open.getsession.org; decoding was also checked against real posts there.https://claude.ai/code/session_019cnvrsCXsqLykDyQburD2f