Repository navigation
Python(feat): batch measurement upload - #810
Merged
Merged
Conversation
alexluck-sift
changed the base branch from
main
to
al/python/fix/pytest-update-with-no-mask
October 1, 2026 00:40
alexluck-sift
added this pull request to stack #811
October 1, 2026 00:40
Base automatically changed from
al/python/fix/pytest-update-with-no-mask
to
main
October 1, 2026 16:55
A test-results log records one CreateTestMeasurement line per measurement, and replay sent one request for each. Measurements are the bulk of a log, so a large log took one round trip per measurement to upload. Replay now coalesces a run of consecutive measurement lines into one CreateTestMeasurements call. A run ends at the next non-measurement line, at the size guard, or at the end of the log, so lines still reach the server in log order and the cursor advances by the whole run once its call returns. On a 13,631-line log this takes the requests from 13,628 to 4,021, and the upload from about 12 minutes to about 3.5 at a 53ms round trip. The sidecar is written once per run rather than once per line, which cuts its cost with them. The log format does not change, so a log written by an earlier version gets the same speedup. Step creates and updates still take one request each.
alexluck-sift
force-pushed
the
al/python/feat/batch-measurements
branch
from
October 14, 2026 18:43
658e6a3 to
07f59ad
Compare
Contributor
|
Python docs preview: https://sift-stack.github.io/sift/python/pr-810/ Deployed from |
alexluck-sift
changed the title
alexluck-sift
marked this pull request as ready for review
October 15, 2026 21:51
ian-sift
reviewed
Oct 15, 2026
ian-sift
reviewed
Oct 16, 2026
ian-sift
reviewed
Oct 19, 2026
ian-sift
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaying a test-results log batches consecutive measurement creates into one
CreateTestMeasurementscall instead of one call per measurement. On a 13,631-line log this cut the calls from 13,628 to 4,021 and the upload from about 12 minutes to about 3.5; step creates and updates still take one call each.SiftReplayReconciledWarning.<log>.stopfile on Windows) so its progress is saved, and is killed only after a further 30s.