Repository navigation
Conversation
love-linger
added a commit
that referenced
this pull request
Oct 15, 2026
…ry changed (#2785) Signed-off-by: leo <longshuang@msn.cn>
Collaborator
|
I've pushed my fixed for this BUG. |
love-linger
added a commit
that referenced
this pull request
Oct 15, 2026
…ry changed (#2785) Signed-off-by: leo <longshuang@msn.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a workspace is renamed via the "Configure Workspace" dialog, the main window title (shown in the taskbar) keeps displaying the old name until the next
ActivePage/ActiveWorkspacechange triggersPostActivePageChanged().Root Cause
Launcher.Titleis a snapshot string built inPostActivePageChanged(). Nothing subscribes toWorkspace.Namechanges, so renaming the active workspace never rebuilds the title.Changes
src/ViewModels/Launcher.csWorkspace.PropertyChangedin theActiveWorkspacesetter (unsubscribing the previous workspace to avoid stale handlers).OnActiveWorkspacePropertyChanged, which callsPostActivePageChanged()whenNamechanges on the active workspace.The existing
_ignoreIndexChangeguard insidePostActivePageChanged()prevents redundant rebuilds duringSwitchWorkspace().Test