Repository navigation
Conversation
A Capybara node holds the session, and through it the driver and the browser connection. Walking its instance variables to build a failure message can take minutes with CDP-based drivers, so nodes are rendered with Capybara's own #inspect.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a failing expectation involves a Capybara element (e.g.
expect(page.find("button")).to be_disabled), SuperDiff builds the failure message by walking the element's instance variables.An element holds the session, and through it the driver and the browser connection (pages, network traffic, sockets). With CDP-based drivers like Cuprite/Ferrum this takes minutes, so the spec looks like it's hanging.
This adds an inspection tree builder for
Capybara::Node::BaseandCapybara::Driver::Nodethat uses Capybara's own#inspect(e.g.#<Capybara::Node::Element tag="h1" path="/html/body/h1">), mirroring the existingActionDispatch::Requestbuilder. It's loaded bysuper_diff/rspecwhen Capybara is present, or explicitly viarequire "super_diff/capybara".Capybara is added to the Rails appraisals so the unit specs can run against a real rack_test session.