Repository navigation
Conversation
SqlParameterSourceUtils.createBatch wraps every candidate that is not a Map in a BeanPropertySqlParameterSource, so an SqlParameterSource passed in is exposed through its own bean properties instead of its parameter values. This commit returns such a candidate as-is, as JdbcClient now does for paramSource(Object) and its batch entries. Signed-off-by: lejuho <zedd1324@gmail.com>
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
changed the title
SqlParameterSource as-is in SqlParameterSourceUtils.createBatch()
sbrannen
added
type: enhancement
Member
|
This has been merged into Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SqlParameterSourceUtils.createBatch(Collection)(and thecreateBatch(Object...)variant that delegates to it) wraps every candidate that is not aMapin aBeanPropertySqlParameterSource. AnSqlParameterSourcepassed in, for example aMapSqlParameterSourcebuilt for one batch entry, is then read through its own bean properties (values,parameterNames, ...) instead of its parameter values, soNamedParameterJdbcTemplate.batchUpdatefails with "No value supplied for the SQL parameter".This change returns such a candidate as-is, the same way
JdbcClientnow resolvesparamSource(Object)and its batch entries (gh-37501), and mentions it in the Javadoc of bothcreateBatchvariants.SqlParameterSourceUtilsTestsis new, ascreateBatchhad no tests. It covers a mixed batch of aMap, a bean and anSqlParameterSource, and the varargs variant. Both tests fail without the change../gradlew :spring-jdbc:test --tests 'org.springframework.jdbc.core.namedparam.*' :spring-jdbc:checkstyleMain :spring-jdbc:checkstyleTestpasses.