Skip to content

feat: Harden the operator Deployment - #785

Merged
lfrancke merged 2 commits into
mainfrom
feat/harden-operator-deployment
Oct 22, 2026
Merged

lfrancke merged 2 commits into
mainfrom
feat/harden-operator-deployment

Conversation

@lfrancke

Copy link
Copy Markdown
Member

Description

Part of stackabletech/issues#903, same change as stackabletech/trino-operator#963. See there for the description and testing.

Definition of Done Checklist

Author

  • Changes are OpenShift compatible
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)

Reviewer

  • Code contains useful comments
  • Changelog updated

Acceptance

  • Proper release label has been added
  • Release note snippet added

@lfrancke lfrancke self-assigned this Oct 22, 2026
@lfrancke lfrancke moved this to Development: Waiting for Review in Stackable Engineering Oct 22, 2026
@lfrancke
lfrancke enabled auto-merge October 22, 2026 13:08
@adwk67
adwk67 self-requested a review October 22, 2026 13:56
@adwk67 adwk67 moved this from Development: Waiting for Review to Development: In Review in Stackable Engineering Oct 22, 2026

@adwk67 adwk67 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The smoke test does not pass for me on Openshift. Something no longer matches in the 60-assert step.

Update: I was in the wrong branch :| Am re-checking....
I am now getting:
Caused by: org.apache.hadoop.hive.metastore.api.MetaException: Request denied due to database_allow authorization policy.
(not the cause)
This seems to be the problem in the assert (Statefulset):
generation: 1
We should probably remove that.

@lfrancke

Copy link
Copy Markdown
Member Author

Thanks! I didn't run the tests :( I'll take a look!

@adwk67

adwk67 commented Oct 22, 2026

Copy link
Copy Markdown
Member

It works when I remove that line. Claude indicates it is race condition when the restarter fires if the hive cluster is being started before all dependencies (s3 etc.) are finished.

@lfrancke

Copy link
Copy Markdown
Member Author

Ah...so nothing at all to do with this change?

@adwk67

adwk67 commented Oct 22, 2026

Copy link
Copy Markdown
Member

Nope, I don't think so.

@adwk67 adwk67 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failing test was due to a race condition and not due to these changes.

@lfrancke
lfrancke added this pull request to the merge queue Oct 22, 2026
@lfrancke lfrancke moved this from Development: In Review to Development: Done in Stackable Engineering Oct 22, 2026
Merged via the queue into main with commit 988489c Oct 22, 2026
13 checks passed
@lfrancke
lfrancke deleted the feat/harden-operator-deployment branch October 22, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Done

Development

Successfully merging this pull request may close these issues.

2 participants