Repository navigation
Remove STACKMAN_HAVE_CALL in 1.4.0. - #26
Open
kristjanvalur wants to merge 1 commit into
Open
kristjanvalur wants to merge 1 commit into
kristjanvalur wants to merge 1 commit into
Conversation
Every supported ABI already provides stackman_call. The macro only decided whether test_04 and test_05 were compiled. STACKMAN_STACK_ALIGN stays visible from a normal stackman.h include. This is for 1.4.0, not a 1.3.x patch.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every supported ABI provides
stackman_call.STACKMAN_HAVE_CALLwas always1, and its only use was to compiletest_04andtest_05. Those tests now always build.STACKMAN_STACK_ALIGNis unchanged, and it is still defined from a normal#include "stackman.h".This is for 1.4.0. It does not belong in a 1.3.x patch.
STACKMAN_VERSIONstays1.3.0until that release. The historical note indocs/abi-register-audit.mdis left as it was.Closes #16.