Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opening any dropdown inside a Bard set (the set's own menu, a nested Replicator set's menu, a stacked Grid row's menu) recreates the set's NodeView and the menu closes immediately, whenever the set has other nodes on both sides of it. Reka's modal menu runs
hideOthers, which stampsaria-hiddenon every sibling along the trigger's ancestor path, including the editor's other top-level nodes. ProseMirror sees those attribute mutations on its own paragraph/heading DOM, re-parses the range between them, and the set in between is replaced. Nested fields lose their state, e.g. an expanded Replicator snaps shut.Dropdownnow renders non-modal when the existingisInBardFieldinjection is present, so nothing inside the editor gets markedaria-hidden. Dropdowns elsewhere are unchanged. Verified in a sandbox with Playwright: all three menus open and the set element survives.Related to #15687 (the remount that resets a nested Replicator's collapsed state); #15688 and #15689 cover the save-driven rebuilds.