Repository navigation
fix(core): fix IProtoBegin timeout bug - #132
Merged
Merged
Conversation
Fixed a bug: the timeout in IProtoBegin was being specified in milliseconds (as a `long`), but the protocol requires the timeout to be passed in seconds (as a `double`) https://www.tarantool.io/ru/doc/latest/reference/internals/iproto/streams/#iproto-begin.
nickkkccc
force-pushed
the
fix-iproto-begin-bug
branch
from
October 20, 2026 14:13
455ed44 to
6dbeffe
Compare
bitgorbovsky
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed a bug: the timeout in IprotoBegin was being
specified in milliseconds (as a
long), butthe protocol requires the timeout to be passed
in seconds (as a
double)https://www.tarantool.io/ru/doc/latest/reference/internals/iproto/streams/#iproto-begin.
I haven't forgotten about:
Related issues: