Repository navigation
Update FatFs to R0.16 w/patch2 - #520
Merged
Merged
Conversation
Owner
|
Thank you, Ada! This is probably quite overdue, I'm glad you tackled it. |
Contributor
Author
Not really, none of the changes turn out to be very relevant to anything (I guess FatFs is the mythical DONE project!) Mostly concerning ExFAT and features the VFS doesn't use. flexspin's stack also grows upwards, which makes it inherently safer against buffer overflows. You know, in case an evil maid visits by your house and really wants to pwn your P2 board. BTW check out this slop if you want to have a laugh: https://github.com/runZeroInc/vulns-2026-fatfs-chance |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Diff is annoying to read due to many formatting/comment changes (doesn't smell too sloppy but idk it's strange).
Most changes appear to concern ExFAT, which was actually broken and couldn't be enabled. I didn't test it beyond building, but I did add optimized versions of the 64 bit load/store functions that were missing.
Additional bloat vs. old version appears (after patching a rough spot) to be 20 to 32 bytes in practice. Not too terrible.