Repository navigation
Conversation
A bound attribute's, event's, reference's or variable's key span is the identifier without its binding syntax: `user` in `[user]`, `click` in `(click)`, `prop` in `[(prop)]`, `bind-prop` and `bindon-prop`, `a` in `#a`, `ref-a` and `let-a`. A legacy animation's `@` or `animate-` is not part of it either. This follows `createKeySpan` in `parseAttribute` (r3_template_transform.ts) and the adjustments of `parsePropertyBinding`, `parseLiteralAttr` and `parseEvent` (binding_parser.ts), for elements and for selectorless directives. The type checker writes these spans into its output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The R3 transform gave every bound attribute, event and reference the whole attribute name as its
key_span([user]), where Angular'screateKeySpan(r3_template_transform.ts) covers only the identifier (user):key_spanbefore[user]="x"[user]user(click)="f()"(click)click[(value)]="v"[(value)]valuebind-prop,on-event,bindon-propprop,event,prop#a,ref-a,let-aaLegacy animations drop
@andanimate-as binding_parser.ts does. Interpolated attributes keep the whole name, andattr.,class.andstyle.stay in the key, as in Angular. Template attributes and selectorless directives are covered too.Nothing in the compiler reads key spans, so its output is unchanged; tools built on the R3 AST need them to match Angular's (a template type checker maps diagnostics on bindings through them).
key_span_testscovers bound attributes,bind-/@/animate-, interpolation, events, two-way bindings, references and variables, and template attributes, with expected values from Angular'sr3_ast_spans_spec.ts. The conformance suite passes with its snapshot unchanged.