Repository navigation
perf: select project Node before installation - #202
Conversation
fengmk2
changed the title
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
25c45da to
c7ac579
Compare
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
CI setup can download two Node.js versions when the project selection differs from the installer's LTS runtime. The installer keeps the latest Node.js LTS as its default. Project files, session overrides, and user defaults do not change its installation runtime. `VP_SETUP_NODE_VERSION` selects another Node.js version for dependency installation. The installer resolves that value once and uses it when the CLI and pinned `pnpm` support it. Otherwise, installation uses LTS. `VP_SETUP_NODE_VERSION_FILE` returns the exact requested version, including when installation needs LTS. Project discovery belongs to `setup-vp`, which supplies the environment override. Related integration: [setup-vp #202](voidzero-dev/setup-vp#202).
2 participants
CI setup can install an extra Node.js LTS runtime before it selects the project's requested version.
setup-vpnow reads the selection before installation and passes it throughVP_SETUP_NODE_VERSIONacross GitHub Actions, GitLab, and Azure.node-versiontakes precedence overnode-version-file. Without explicit inputs, discovery checks.node-version,package.json#devEngines.runtime,package.json#engines.node, then.nvmrcin each directory before its parent.Compatible installers return the exact version for explicit
vp env userequests. Automatic discovery keeps its directory scope. With no selection or withnode-manager: false, the installer keeps its LTS default. Older installers retain the existing behavior.Runtime reuse requires a Vite+ release with the installer change. The installer itself does not discover project versions.
Benchmark
Both cases use Vite+ preview
65f9bc5and project Node.js22.23.1. The control usessetup-vpatad00cb8with the default LTS installer runtime. The updated case uses25c45daand passes the project version throughVP_SETUP_NODE_VERSION.The table shows median setup time from 12 samples per case on each OS, across two workflow runs. Each installation uses fresh local runtime and package caches. Installation order rotates between samples. Timing covers
setup-vpexecution, including Node.js activation. It excludes checkout and application dependency installation.Every optimized installation downloaded only project Node.js
22.23.1. Each control installation also downloaded LTS24.22.0. Network variation affects individual measurements, especially on Windows; these figures are observed median savings.The workflow artifacts contain the raw timings and logs: first run, second run.