Skip to content

chore(lint): enable e18e rules - #205

Merged
fengmk2 merged 1 commit into
mainfrom
chore/e18e-eslint-plugin
Oct 16, 2026
Merged

fengmk2 merged 1 commit into
mainfrom
chore/e18e-eslint-plugin

Conversation

@fengmk2

@fengmk2 fengmk2 commented Oct 16, 2026

Copy link
Copy Markdown
Member

Enable @e18e/eslint-plugin in the existing Vite+ configuration to detect inefficient code patterns. The configuration enables 16 rules compatible with Oxlint and the project’s ES2023 types.

Move reusable regular expressions to module constants and update the three runtime bundles. Keep regular expressions inline in tests. Exclude the plugin from Fallow’s unused dependency check because Oxlint loads it through lint.jsPlugins.

@socket-security

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Added@​e18e/​eslint-plugin@​0.8.110010010092100

View full report

@fengmk2

fengmk2 commented Oct 16, 2026

Copy link
Copy Markdown
Member Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-16T17:51:16.643126Z e110396 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Delightful!

Reviewed commit: e110396eb7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@fengmk2
fengmk2 merged commit 09d608a into main Oct 16, 2026
83 checks passed
@fengmk2
fengmk2 deleted the chore/e18e-eslint-plugin branch October 16, 2026 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant