Repository navigation
fix: preserve custom TanStack Worker entries and prepare native Cloudflare output #444
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shrek-kurata
wants to merge
6
commits into
voidzero-dev:main
Choose a base branch
from
shrek-kurata:fix/tanstack-custom-entry-cf-build-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a49f8bf
fix: preserve custom TanStack Worker entries and expose CF build outp…
shrek-kurata 018b0ec
feat: prepare native Cloudflare build output without changing inputs
shrek-kurata 03e1309
fix: keep custom TanStack entries through deploy and settle the build…
Brooooooklyn 36e6f64
fix: keep entry handlers through deploy and read cloudflare.main with…
Brooooooklyn 109a01b
fix: read any existing app file as the custom TanStack entry
Brooooooklyn 499b5a2
test: lock in that native Build Output refuses asset symlinks
Brooooooklyn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When native
.cloudflare/output/v0assets contain a symlink, thiscpSyncneither callsassertAssetSymlinksInsidenor dereferences the link; Node's default copy preserves it and resolves its target back into the original source tree. The returned artifact can therefore stop being self-contained when the source moves, and an escaping link can cause a later asset upload to read a file outside the asset directory, even though the public API promises that such links throw. Validate and materialize native asset links just as the legacy branch does.Useful? React with 👍 / 👎.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, but this cannot happen:
prepareNativeBuildOutputfirst callsreadBuildOutput(source), which refuses any symlink in the native output, assets included, beforecpSyncruns ("Build Output Specification: symlink found at …/assets/…. Symlinks are not permitted because the build output must be portable and self-contained."). A link inside the asset directory is refused too, so there is nothing to validate or materialize at the copy. 499b5a2 adds a test that locks this in:rejects symlinked native assetsincf-build-output.test.ts. Leaving this thread open for the maintainer.