Skip to content

chore: run package scripts through pnpm’s shell emulator - #464

Open
JianJroh wants to merge 1 commit into
voidzero-dev:mainfrom
JianJroh:chore/pnpm-shell-emulator
Open

JianJroh wants to merge 1 commit into
voidzero-dev:mainfrom
JianJroh:chore/pnpm-shell-emulator

Conversation

@JianJroh

Copy link
Copy Markdown

📄 Description

Enables pnpm's shell emulator so root package scripts that pass single-quoted --filter globs work on Windows. Without it, pnpm runs scripts through cmd.exe, which keeps the quotes, so the glob isn't parsed and the command fails with failed to parse glob expression. Affects pnpm build, pnpm check, pnpm check:sdk, pnpm check:platform, pnpm build:platform, and pnpm test:platform; no change on POSIX, where the shell already handles the quoting.

🧪 Reproduction

$ pnpm build
$ vp run --filter './packages/**' --parallel build
error: Invalid vite task command: vp with args []
* invalid --filter expression
* failed to parse glob expression
[ELIFECYCLE] Command failed with exit code 1.
Testing steps
  • Reproduced with shellEmulator: false: pnpm build exits 1 with the glob-parse error above.
  • Set shellEmulator: true; verified pnpm config get shell-emulator returns true and pnpm build completes.
  • Audited all workspace package.json scripts: only the root ones use single quotes, and none rely on cmd.exe-specific syntax, so the emulator has no side effects.

@JianJroh
JianJroh requested a review from a team as a code owner October 17, 2026 06:47

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant