Repository navigation
test(extension): scrape until the job metrics settle - #35
Merged
Merged
Conversation
The v1.9.0 release run failed on TestExtensionRecordsThroughForge. The test scraped once, right after it saw the "process job" span end, but the worker drops dispatch_jobs_active back to 0 just after that span ends, so a quick scrape could still read 1. The test now scrapes until every expected series is there (up to 5s) and then checks. It passed 200 runs under -race, and 100 more with GOMAXPROCS=2 on a loaded machine.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.9.0 release run failed in its verify step on one flaky test,
TestExtensionRecordsThroughForge. The tag got pushed, but there's no GitHub release, so this goes out as v1.9.1.The test scraped
/_/metricsonce, the moment it saw theprocess jobspan end. The worker setsdispatch_jobs_activeback to 0 just after that span ends, so a fast scrape could still read 1. Nothing is wrong with the metric itself.The test now scrapes until every series it expects is there, for up to 5 seconds, and then checks. It passed 200 runs under
-race, and another 100 withGOMAXPROCS=2on a loaded machine. No other test scrapes once like this.After merge: