Repository navigation
Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 2 | Implement and rewrite tests - #1685
Open
chefmatthaus-hub wants to merge 3 commits into
Open
chefmatthaus-hub wants to merge 3 commits into
chefmatthaus-hub wants to merge 3 commits into
Conversation
chefmatthaus-hub
added
the
Needs Review
hackertainment
added
Review in progress
hackertainment
left a comment
hackertainment
left a comment
There was a problem hiding this comment.
The code generally looks good to me. Just need to fix test cases for proper fraction. Your are almost there, and keep it up :-)
There was a problem hiding this comment.
It seems to me that there are redundant and missing test cases:
- About zero cases, you have tested
(0, 1)(1, 0)and(-1, 0)but missed a case. - About non-zero (numerator≠denominator) case, you have included
(-1, -2)(1, -2)(-1, 2)and(1, 2)but they are all numerator less than denominator (if not considering the negative sign). How about numerator greater than denominator with negative numbers? Since(9, 8)(4, 2)(5, 3)(6, 4)(7, 1)(15, 14)are all testing the same scenario, there would be 3 other combinations missing. - About non-zero (numerator=denominator) case, you have tested positive number
(4, 4)but missing the negative number.
So please add the missing cases (and optionally remove redundant cases as well). Thank you.
There was a problem hiding this comment.
Looked much better now, and hope you now understand the test case design process.
There was a problem hiding this comment.
Same comment as https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1685/changes#r4308748253
Please add the missing cases (and optionally remove redundant cases as well). Thank you.
hackertainment
added
Reviewed
chefmatthaus-hub
added
the
Needs Review
|
Congratulation, you have completed this PR successfully. |
hackertainment
added
Complete
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Self checklist
Task code
CYF-1059
Removed redundant test cases and improved test coverage