Repository navigation
Cape Town | sep-2026-ITP | Matthaus Bause | Sprint 2 | Implement and rewrite tests #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Same comment as https://github.com/CodeYourFuture/Module-Structuring-and-Testing-Data/pull/1685/changes#r4308748253 There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Well done. |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,61 @@ | ||
| import { isProperFraction } from "../implement/2-is-proper-fraction.js"; | ||
|
|
||
| // TODO: Write tests in Jest syntax to cover all combinations of positives, negatives, zeros, and other categories. | ||
|
|
||
| // Special case: numerator is zero | ||
| test(`should return false when denominator is zero`, () => { | ||
| expect(isProperFraction(1, 0)).toEqual(false); | ||
| }); | ||
|
|
||
| test(`should return false when numerator equals the denominator`, () => { | ||
| expect(isProperFraction(4, 4)).toEqual(false); | ||
| }); | ||
|
|
||
| test(`should return false if 15/14`, () => { | ||
| expect(isProperFraction(15, 14)).toEqual(false); | ||
| }); | ||
|
|
||
| test(`should return false if numerator is negative and denominator is zero`, () => { | ||
| expect(isProperFraction(-1, 0)).toEqual(false); | ||
| }); | ||
|
|
||
| test(`should return true if numerator is negative and denominator is positive`, () => { | ||
| expect(isProperFraction(-1, 2)).toEqual(true); | ||
| }); | ||
|
|
||
| test(`should return true if numerator is positive and denominator is negative`, () => { | ||
| expect(isProperFraction(1, -2)).toEqual(true); | ||
| }); | ||
|
|
||
| test(`should return true if both numerator and denominator is negative`, () => { | ||
| expect(isProperFraction(-1, -2)).toEqual(true); | ||
| }); | ||
|
|
||
| test(`should return true if numerator is zero and the denominator is positive`, () => { | ||
| expect(isProperFraction(0, 1)).toEqual(true); | ||
| }); | ||
|
|
||
| test(`should return true for a basic proper fraction`, () => { | ||
| expect(isProperFraction(1, 2)).toEqual(true); | ||
| }); | ||
|
|
||
| test("Returns false when both numerator and denominator are zero", () => { | ||
| expect(isProperFraction(0, 0)).toEqual(false); | ||
| }); | ||
|
|
||
| test("Return true when numerator is zero and denominator is negative", () => { | ||
| expect(isProperFraction(0, -2)).toEqual(true); | ||
| }); | ||
|
|
||
| test("Returns false when positive numerator has greater magnitude than negative denominator", () => { | ||
| expect(isProperFraction(3, -2)).toEqual(false); | ||
| }); | ||
|
|
||
| test("Returns false when both numbers are negative and numerator has greater magnitude", () => { | ||
| expect(isProperFraction(-3, -2)).toEqual(false); | ||
| }); | ||
|
|
||
| test("Returns false when negative numerator has greater magnitude than positive denominator", () => { | ||
| expect(isProperFraction(-3, 2)).toEqual(false); | ||
| }); | ||
|
|
||
| test("Returns false when numerator and denominator are equal negative numbers", () => { | ||
| expect(isProperFraction(-4, -4)).toEqual(false); | ||
| }); |
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to me that there are redundant and missing test cases:
(0, 1)(1, 0)and(-1, 0)but missed a case.(-1, -2)(1, -2)(-1, 2)and(1, 2)but they are all numerator less than denominator (if not considering the negative sign). How about numerator greater than denominator with negative numbers? Since(9, 8)(4, 2)(5, 3)(6, 4)(7, 1)(15, 14)are all testing the same scenario, there would be 3 other combinations missing.(4, 4)but missing the negative number.So please add the missing cases (and optionally remove redundant cases as well). Thank you.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looked much better now, and hope you now understand the test case design process.