Repository navigation
style: Fix formatting in data viewer tests - #1891
Merged
Merged
Conversation
Co-authored-by: eitsupi <50911393+eitsupi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix the failing GitHub Actions job format
Fix formatting in data viewer tests
Oct 21, 2026
eitsupi
marked this pull request as ready for review
October 21, 2026 04:00
eitsupi
approved these changes
Oct 21, 2026
renkun-ken
approved these changes
Oct 21, 2026
renkun-ken
left a comment
Member
There was a problem hiding this comment.
Reviewed f4f06bc. No actionable issues found.
The diff is limited to formatting in src/test/suite/dataViewer.test.ts. Applying the pinned oxfmt 0.73.0 to the base version reproduces the PR file byte for byte, and the base and head versions produce identical normalized JavaScript with esbuild.
Validation: oxfmt --check . passes for all 181 matched files, and git diff --check passes. GitHub CI is also green for format, lint, build, and the macOS, Ubuntu, and Windows test jobs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
formatjob failed becausesrc/test/suite/dataViewer.test.tsdid not match the configured formatter.oxfmtformatting to the test file; no test behavior changed.