Skip to content

style: Fix formatting in data viewer tests #1891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eitsupi merged 2 commits into from
Oct 21, 2026
Merged

style: Fix formatting in data viewer tests #1891

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f8730e2
Initial plan
Copilot Oct 21, 2026
f4f06bc
fix format check for data viewer tests
Copilot Oct 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 35 additions & 13 deletions src/test/suite/dataViewer.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
import * as assert from 'assert';
import * as vm from 'vm';
import type { ColDef, ColumnState, GridOptions, GridState, IFilterOptionDef, ITextFilterParams } from 'ag-grid-community';
import type {
ColDef,
ColumnState,
GridOptions,
GridState,
IFilterOptionDef,
ITextFilterParams,
} from 'ag-grid-community';
import { getDataViewerScript } from '../../dataViewer';

interface SavedViewer {
Expand Down Expand Up @@ -270,34 +277,49 @@ suite('Data viewer', () => {
script.prepareViewerColumns(defs);
const params = defs[0].filterParams as ITextFilterParams;
assert.deepStrictEqual(Array.from(params.buttons ?? []), ['reset', 'apply']);
assert.deepStrictEqual(Array.from(params.filterOptions ?? [], option =>
typeof option === 'string' ? option : option.displayKey
), ['empty', 'true', 'false', 'blank']);
assert.deepStrictEqual(Array.from(params.filterOptions ?? [], option =>
typeof option === 'string' ? option : option.displayName
), ['empty', 'True', 'False', 'blank']);
assert.deepStrictEqual(
Array.from(params.filterOptions ?? [], (option) =>
typeof option === 'string' ? option : option.displayKey,
),
['empty', 'true', 'false', 'blank'],
);
assert.deepStrictEqual(
Array.from(params.filterOptions ?? [], (option) =>
typeof option === 'string' ? option : option.displayName,
),
['empty', 'True', 'False', 'blank'],
);
// Preserve AG Grid's "Choose one" and "Blank" labels.
assert.strictEqual(script.getViewerGridOptions(500).localeText?.empty, undefined);
assert.strictEqual(script.getViewerGridOptions(500).localeText?.blank, undefined);
});

for (const [key, expected] of [['true', true], ['false', false]] as const) {
for (const [key, expected] of [
['true', true],
['false', false],
] as const) {
test(`logical ${key} filter matches only its value, excluding NA`, () => {
const script = viewerScript().script;
const defs: ColDef[] = [{ field: '1', type: 'booleanColumn' }];
script.prepareViewerColumns(defs);
const params = defs[0].filterParams as ITextFilterParams;
const option = params.filterOptions?.find((candidate): candidate is IFilterOptionDef =>
typeof candidate !== 'string' && candidate.displayKey === key
const option = params.filterOptions?.find(
(candidate): candidate is IFilterOptionDef =>
typeof candidate !== 'string' && candidate.displayKey === key,
);
assert.ok(option?.predicate);
assert.strictEqual(option.numberOfInputs, 0);
const predicate = option.predicate;
const rows = script.prepareViewerRows(
[true, false, null, undefined].map(value => ({ '1': value })), []
[true, false, null, undefined].map((value) => ({ '1': value })),
[],
);
assert.deepStrictEqual(
rows
.filter((row) => Reflect.apply(predicate, undefined, [[], row['1']]))
.map((row) => row['1']),
[expected],
);
assert.deepStrictEqual(rows.filter(row => Reflect.apply(predicate, undefined, [[], row['1']]))
.map(row => row['1']), [expected]);
});
}

Expand Down
Loading