[m-muecke]

follows the rest of the file, about 1.5x faster

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.08%. Comparing base (7b7f63b) to head (9c30a06).

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #7930   +/-   ##
=======================================
  Coverage   99.08%   99.08%           
=======================================
  Files          88       88           
  Lines       17420    17421    +1     
=======================================
+ Hits        17261    17262    +1     
  Misses        159      159           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ben-schwen]

Basically yes, but can we write a linter or coccinelle for this, so we avoid this construct in the future?

[m-muecke]

Not a problem, but I don't believe it can be auto-fixed. Should this be a follow-up PR, since the linter rule would flag 117 cases across 12 files, and most of them aren't hot paths.

[aitap]

Probably a follow-up PR, yes. It would be quite interesting to look at the linter. Could you please push it into a separate branch?

[MichaelChirico]

most of them aren't hot paths.

IIUC the change is not bad to make on "slow paths", just that the benefit is small. In that case, I would still make the changes in one clean-up and then guard with a linter -- it's good to be in the habit of making the right choice.