Skip to content

dt_na: hoist COMPLEX_RO() out of the loop #7930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
m-muecke wants to merge 1 commit into
base: master
Choose a base branch
from
+2 −1
Open

dt_na: hoist COMPLEX_RO() out of the loop #7930

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/frank.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ SEXP dt_na(SEXP x, SEXP cols)
break;
case CPLXSXP: {
// taken from https://github.com/wch/r-source/blob/d75f39d532819ccc8251f93b8ab10d5b83aac89a/src/main/coerce.c
for (int j=0; j<n; ++j) ians[j] |= (ISNAN(COMPLEX(v)[j].r) || ISNAN(COMPLEX(v)[j].i));
const Rcomplex *cv = COMPLEX_RO(v);
for (int j=0; j<n; ++j) ians[j] |= (ISNAN(cv[j].r) || ISNAN(cv[j].i));
}
break;
case VECSXP: {
Expand Down
Loading