Repository navigation
Show one look per Bot on every home in face-to-face rooms - #464
Merged
Merged
Conversation
…ls mark (ThinkFlowLab#182) A Bot with no stored look now sends the look its home generates (core defaultShape/defaultColor, mirrored in social look.js and checked equal) to Bot Social, before a new identity joins a room. The waiting dialog finds my own Bot by its room record or this join's joinedAs and uses the roster look. A face room's remote Bot speaks with its seat's look, as Members and tiles draw it. PersonMark draws a person's initial on a name-picked color.
Collaborator
Author
|
Self-review: PASS
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #182
What
characters.js), but Bot Social got nothing, so the other home invented a handle-seeded one.syncBotLooknow sends the look the home draws (shownLookinplugins/social/src/look.js, the same functions as core, checked equal by a test). A stored image or emoji is sent as is, in the orderBotMarkdraws them (image, emoji, shape).registerOncereturns, so the firstmembers[]the peer sees already has it.remote: false, local id) or by this join'sjoinedAs.members[]), the same as Members, the room avatar and the waiting tiles (the teal blob vs blue whale).PersonMark({ name })).Scope. Room titles were made consistent across homes in #186. The number in the title and the Past rows are #304, and own-bubble avatars are #457, so neither is in this PR. Two Bots that both carry the owner-stored default Chief look (whale) still look the same: each home draws its owner's own look, and the owner name tells them apart.
Test
ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass, 0 failures (core 1019, social 279, tree 80, timeline 80, scripts, interop, live-e2e unit).POST /face-rooms/join. The waiting dialog uses the roster look right after a join and after a poll.remoteSpeakeruses the seat look in a face room. PersonMark draws the initial and a stable color.Risk tier: T3 (estimate, matching the risk-tier report check; the controller sets the label)