Repository navigation
Face room lifecycle: unknown number opens no room, room stays open while 2+ people remain (#458) - #467
Merged
Conversation
…ile 2+ people remain (ThinkFlowLab#458)
Collaborator
Author
|
Self-review: PASS
|
This was referenced Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #458
What
Dateheader (3 s threshold), and the timer re-renders when the tab becomes visible again.Why
These are the expectations recorded in #458, plus the owner decision of 2026-10-20: an unknown number does not open a room, and a room stays open while at least 2 people are in it.
This is FlyBot-only, with no Bot Social server change. Bot Social still creates a candidate for an unknown number on join. FlyBot holds it off-screen for at most 2 minutes. It reuses that candidate if the owner presses Start (no second create against the 3/hour limit) and otherwise leaves it.
Test
ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass, 0 failures (core 1021, social 290, other suites all pass).faceRowTitleandawayGroups.Risk tier: T3 (estimate; the controller sets the label)