[Birfy]

Part of #355 (first slice per the Owner decision: email to yourself; Slack, retries/delivery log and the 24/7 runtime stay open there).

What. With your opt-in (Settings → General → Email me, off by default), the events behind the system notifications of #353 — one of your own Bots finished or failed a turn, or an approval started waiting — also go to your own address: one short line each (who, what, group name) plus a link back into FlyBot. No chat text, tool name or arguments; "Approve or reject only in FlyBot. Replies to this email are not read." One email per one-minute batch, at most one every five minutes; approvals answered before the send are left out; switching off drops what waits.

How. New core/src/host/email.js: settings from the environment only (FLYBOT_SMTP_URL = your own SMTP account, smtps:// or smtp:// + STARTTLS; FLYBOT_EMAIL_TO = the only recipient; FLYBOT_URL = the link). Minimal SMTP client on node:net/node:tls with certificate checks; a password is never sent without TLS; a failure is logged with its code only, never the server's text or the password. Hooks: one line each in turns.js (noteEnded) and approvals.js. View carries email: { to } | null (hidden with more than one member, authz.js); set-prefs takes email and refuses true when nothing is set up. Only while the deployment has one member. compose.yaml passes the three variables through; guide in docs/docker.md (+ zh). No new dependency, no paid service, no relay we run.

Test. core/test/email.test.js (config parsing and rejection of malformed values/header injection, message encoding, SMTP exchange against a local fake server, password refused without TLS, reply-code-only errors, batching/gap, off by default / multi-member / unset / switched off, answered approvals dropped, approvals hook), turn hook in approval-notices.test.js, set-prefs in install.test.js, compose passthrough in docker-profile.test.mjs. ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify passes. Ad hoc (not committed): STARTTLS + AUTH PLAIN and implicit TLS against a local TLS server with a self-signed cert trusted via NODE_EXTRA_CA_CERTS, a wrong password gives SMTP_535, an untrusted cert is refused.

Risk tier: T3 (estimate; the controller sets the label) — sends email off the box, touches authz.js / channel.js.

[Birfy]

Self-review: PASS
Tip SHA: 3d0c4a1
Ran:

• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: pass (core lint + arch-docs OK, plugin lint, client bundle check, ds-bot patches check, core 1086/1086, social 296/296, tree 80/80, timeline 83/83, .github scripts 93/93, interop 37/37, live-e2e 16/16)
• node .github/scripts/changelog.mjs check: 18 fragments well formed
• CI at this SHA: all green (tests-ok, test, plugins social/tree/timeline, package, Docker build and start check, risk tier T3 report)
• Ad hoc, not committed: STARTTLS + AUTH PLAIN and implicit TLS (smtps) against a local TLS SMTP stub with a self-signed cert trusted via NODE_EXTRA_CA_CERTS; wrong password → SMTP_535; untrusted cert → refused (DEPTH_ZERO_SELF_SIGNED_CERT)
• Design rules checked: an email carries no approval path (no link that approves, "Replies to this email are not read"; approve only via in-app buttons); recipient is only the owner's own FLYBOT_EMAIL_TO; switch off by default; SMTP password never saved, shown, logged or sent without TLS; no connector token path touched; English UI with zh strings; no new menu or section; scope limited to the first slice (Slack, retries/delivery log, 24/7 runtime stay in Proactive reminders 3/3: 24/7 runtime and Slack/email delivery #355)
  Not run:
• A real mail provider (Gmail/Outlook SMTP) end to end, and the Docker image with SMTP variables set
• Live Mac instances and the DSH Web UI by hand (the Email me switch was checked through tests and the bundle build only)

[Birfy]

Self-review: PASS
Tip SHA: 8eff14c
Ran:

• Merged origin/main (303c0d6, includes Fit chat approvals and the Agent inbox to a phone-width screen #481/Keep live shares in People with access using Bot Social's reply_only #501/Show a friend's first line and its approval card live: read friends' inboxes fast while a window is on screen #505) into feat/355-email-to-self; conflicts only in generated patches 0005/0008 (regenerated via build-client + ds-bot-patches) (2026-10-20 15:03 Asia/Shanghai).
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify: passed (core lint + arch-docs OK, plugin lint OK, build-client --check OK, ds-bot-patches check OK; core/social/tree/timeline/scripts/interop/live-e2e all green).
  Not run:
• Live Mac instances or the production Bot Social server (not touched).

[Birfy]

Self-review: PASS
Tip SHA: d0f0b27
Ran:

• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (pass)
• reviewed diff at tip vs owner design rules
  Not run:
• live Mac instances / production Bot Social

[Birfy]

Self-review: PASS
Tip SHA: d067b0e
Ran:

• git merge origin/main (eb91742, after Remind about approvals waiting 15 min, switch each notification kind, one notification per chat #492 and Social: neutral 'You already have …' on a re-accepted invite; clearer Remove confirm #503) into the branch, no rebase or force-push; resolved conflicts with Remind about approvals waiting 15 min, switch each notification kind, one notification per chat #492 by keeping both: channel.js set-prefs handles both email (Proactive reminders 3/3: 24/7 runtime and Slack/email delivery #355) and notify per-kind (Proactive reminders 1/3 follow-up: quiet hours, mute, waiting-too-long #469); Settings → Notifications shows the main switch, the per-kind switches, then Email me; install.test.js keeps both assertion blocks; core-client.md keeps Remind about approvals waiting 15 min, switch each notification kind, one notification per chat #492's bullets plus the Email me bullet; topics.json keeps src/host/approvals.js in 0001
• generated files regenerated, not hand-merged: took main's patches/ds-bot, then (cd core && npm run build), node scripts/ds-bot-patches.mjs generate, then check: ok (10 patches apply cleanly; core/ = ds-bot/ + patches)
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (core lint + arch-docs, plugin lint, build-client --check, ds-bot-patches check, all suites): pass, 0 failures (core 1107, social 309, tree 80, timeline 92, .github scripts 93, interop 37, live-e2e 16)
• CI on this tip: all checks pass (tests-ok, Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, risk tier, reviewed tip); mergeable MERGEABLE, mergeStateStatus CLEAN
• re-read the diff against main at this tip: changelog.d fragment kept, no CHANGELOG.md or ds-bot/ edits, owner design rules kept (approvals only via UI buttons, English UI, no separate Friends' Bots section, no turn limit or Extend in friend chats, connector tokens only at /mcp)
  Not run:
• live Mac instances / production Bot Social

[Birfy]

Self-review (review-pr, Birfy reviewer agent, 2026-10-20 20:41 Asia/Shanghai): PASS (merge-main conflict fix; no feature change)

Tip SHA: 7ef9234
Ran:

• git merge origin/main twice into the branch, no rebase or force-push: first b6e89d2 (after Timeline: an on-demand export endpoint #524, Polish invites and friend chats: friend Bot placeholder, one invite control, Add friend auto-close, Sharing hint #504, Show a tree coordinator its children's runtime load #508, Add an opt-in state journal and a dev replay script #527, Show each scheduled task's last run, and Retry a failed one #494), then cf61952 (after Name a friend's Bot one way and approval cards by the receiving person #502, which landed while this was being checked) → pass. The first merge's only conflict was the generated patches/ds-bot/0001-core-fixes.patch. The second merge was clean. No hand-merged real sources
• generated files regenerated, not hand-merged, after each merge: git checkout origin/main -- patches/ds-bot, then this PR's topics.json entry restored (src/host/approvals.js in 0001-core-fixes; main's file would otherwise drop it), (cd core && npm run build), node scripts/ds-bot-patches.mjs generate, check → pass (10 patches apply cleanly; core/ = ds-bot/ + patches)
• ARCH_DOCS_BASE=origin/main TZ=UTC npm run verify (core lint + arch-docs OK with 29 changed files, plugin lint, build-client --check, ds-bot-patches check, all suites) → pass, 0 failures (core 1123, social 313, tree 83, timeline 93, .github scripts 93, interop 37, live-e2e 16). A parallel run had one failure in connectors.test.js 'an address saved by an older version…', the known load flake. It passed 3/3 alone, and the full verify rerun passed
• smoke (PR touches core/index.js and core/src/host/): CONTEXT_WINDOW=100000 CHECK_RATIO=0.45 dev/bench.sh smoke493 3296 8996 reset && node dev/smoke.mjs smoke493 3296 against DSH 0.2.0-rc.2, on the cf61952 merge → pass, all 42 steps; bench stopped afterwards
• CI on this tip → all checks pass (tests-ok, ubuntu-latest · Node 24 · DSH 0.2.0-rc.2, plugins social/timeline/tree, package, build and start check, risk tier, reviewed tip); MERGEABLE / CLEAN
• re-read the diff against main at this tip: 29 files, one changelog.d fragment (355-email-to-self.added.md), no CHANGELOG.md or ds-bot/ edits, no node_modules links committed
  Not run:
• live Mac instances / DSH Desktop / real-model live-e2e (no key; mock model only)
• sending a real email (SMTP mocked in tests)
• production Bot Social (not in scope)
  Verdict: PASS

Findings: none to act on. This review does not authorize a merge: risk:T3 still needs the maintainer's approval (the owner queues it).

[Birfy]

Owner decision (2026-10-20 21:12 Asia/Shanghai): closing — won't do.