Repository navigation
chore(deps): update github workflows - #8060
renovate[bot] wants to merge 1 commit into
Conversation
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
Java 25 can break Spark integration tests
The Tasks workflow runs Spark integration environments with Java 25. The configured PySpark 3.5.9 and 4.2.0 environments do not override JAVA_HOME, while those Spark versions document support only through Java 17 and 21, respectively. This can prevent Spark from starting and fail the integration job. Keep Java 21 until these environments are verified on Java 25 or use a compatible JDK for them.
Evidence
FRAMEWORKS_NEEDING_JAVAcontains onlyspark, andtest_group.jinjaconfigures Java 21 for groups that need it; the generated Tasks workflow now configures Java 25.tox.iniincludes Spark environments for PySpark 3.5.9 and 4.2.0, but its Java 11 override applies only to Spark 3.0.3 and 3.5.6.- The Tasks workflow runs
py${{ matrix.python-version }}-spark, so those Spark environments inherit the Java 25 installed by the workflow.
Identified by Warden · code-review · MFU-BC9
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit db98fbd. Configure here.
| with: | ||
| distribution: 'temurin' | ||
| java-version: '21' | ||
| java-version: '25' |
There was a problem hiding this comment.
Java 25 breaks Spark 3 tests
High Severity
Bumping java-version to 25 will fail the Spark 3.5.9 integration tests. pyspark 3.5.9 only supports Java 8, 11, and 17, and Spark 3.x still calls System.setSecurityManager, which JDK 24+ rejects. Those jobs create a SparkContext at fixture setup and will crash on startup. Spark 4.2.0 is unaffected, but 3.5.9 has no JAVA_HOME override.
Reviewed by Cursor Bugbot for commit db98fbd. Configure here.
Coverage Results 📊✅ 132961 passed | ❌ 11 failed | ⏭️ 7276 skipped | Total: 140248 | Pass Rate: 94.8% | Execution Time: 442m 36s 📊 Comparison with Base Branch
➕ New Tests (2)View new tests
❌ Failed Tests
|


This PR contains the following updates:
2.35.0→2.35.17a78575→0ff758921→25Release Notes
getsentry/craft
v2.35.1Compare Source
Bug Fixes 🐛
Deps
Internal Changes 🔧
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.