Skip to content

chore(deps): update github workflows - #8060

Open
renovate[bot] wants to merge 1 commit into
masterfrom
renovate/github-workflows
Open

renovate[bot] wants to merge 1 commit into
masterfrom
renovate/github-workflows

Conversation

@renovate

@renovate renovate Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Type Update Change
getsentry/craft action patch 2.35.0 → 2.35.1
getsentry/craft (changelog) workflow digest 7a78575 → 0ff7589
java-jdk uses-with major 21 → 25

Release Notes

getsentry/craft

v2.35.1

Compare Source

Bug Fixes 🐛
Deps
Internal Changes 🔧

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate
renovate Bot requested a review from a team as a code owner October 19, 2026 11:02
with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 25 can break Spark integration tests

The Tasks workflow runs Spark integration environments with Java 25. The configured PySpark 3.5.9 and 4.2.0 environments do not override JAVA_HOME, while those Spark versions document support only through Java 17 and 21, respectively. This can prevent Spark from starting and fail the integration job. Keep Java 21 until these environments are verified on Java 25 or use a compatible JDK for them.

Evidence
  • FRAMEWORKS_NEEDING_JAVA contains only spark, and test_group.jinja configures Java 21 for groups that need it; the generated Tasks workflow now configures Java 25.
  • tox.ini includes Spark environments for PySpark 3.5.9 and 4.2.0, but its Java 11 override applies only to Spark 3.0.3 and 3.5.6.
  • The Tasks workflow runs py${{ matrix.python-version }}-spark, so those Spark environments inherit the Java 25 installed by the workflow.

Identified by Warden · code-review · MFU-BC9

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Want reviews to match your repository better? Bugbot Learning can learn team-specific rules from PR activity. A team admin can enable Learning in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit db98fbd. Configure here.

with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 25 breaks Spark 3 tests

High Severity

Bumping java-version to 25 will fail the Spark 3.5.9 integration tests. pyspark 3.5.9 only supports Java 8, 11, and 17, and Spark 3.x still calls System.setSecurityManager, which JDK 24+ rejects. Those jobs create a SparkContext at fixture setup and will crash on startup. Spark 4.2.0 is unaffected, but 3.5.9 has no JAVA_HOME override.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit db98fbd. Configure here.

@github-actions

Copy link
Copy Markdown
Contributor

Coverage Results 📊

✅ 132961 passed | ❌ 11 failed | ⏭️ 7276 skipped | Total: 140248 | Pass Rate: 94.8% | Execution Time: 442m 36s

📊 Comparison with Base Branch

Metric Change
Total Tests 📉 -694
Passed Tests 📉 -705
Failed Tests 📈 +11
Skipped Tests —

➕ New Tests (2)

View new tests
  • test_cache_spans_decorator[True]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing
  • test_cache_spans_item_size[True]
    • File: tests.integrations.django.test_cache_module
    • Status: ❌ Failing

❌ Failed Tests

test_cache_spans_decorator[True]

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v6.1.2
Error: tests/integrations/django/test_cache_module.py:384: in test_cache_spans_decorator assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:384: in test_cache_spans_decorator
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

test_cache_spans_item_size[True]

File: tests.integrations.django.test_cache_module
Suite: py3.14-django-v6.1.2
Error: tests/integrations/django/test_cache_module.py:763: in test_cache_spans_item_size assert not spans[0]["attributes"]["cache.hit"] E assert not True

Stack Trace
tests/integrations/django/test_cache_module.py:763: in test_cache_spans_item_size
    assert not spans[0]["attributes"]["cache.hit"]
E   assert not True

✅ Patch coverage is 100.00% (no changed executable lines found; target 80%).
Project statement coverage is 90.26% (unchanged from base (0f7acd5) to head (db98fbd)).

Coverage diff
@@            Coverage Diff             @@
##        master     #8060       +/-##
==========================================
  Coverage    90.26%    90.26%        —%
==========================================
  Files          202       202         —
  Tracked lines     26660     26660         —
  Branches      9926      9926         —
==========================================
  Hits         24062     24062         —
  Misses        2598      2598         —
+ Partials      1510      1509        -1

Generated by Coverage Action

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants