Skip to content

chore(deps): update github workflows #8060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
renovate wants to merge 1 commit into
base: master
Choose a base branch
from
Open

chore(deps): update github workflows #8060

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/changelog-preview.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,6 @@ permissions:

jobs:
changelog-preview:
uses: getsentry/craft/.github/workflows/changelog-preview.yml@7a7857552e2cdc08b502de96e6076849c01fba32 # v2
uses: getsentry/craft/.github/workflows/changelog-preview.yml@0ff75896d43285ca376c7254e8143bac23acd429 # v2
secrets:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ jobs:
token: ${{ steps.token.outputs.token }}
fetch-depth: 0
- name: Prepare release
uses: getsentry/craft@7a7857552e2cdc08b502de96e6076849c01fba32 # 2.35.0
uses: getsentry/craft@0ff75896d43285ca376c7254e8143bac23acd429 # 2.35.1
env:
GITHUB_TOKEN: ${{ steps.token.outputs.token }}
with:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test-integrations-tasks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@
uses: actions/setup-java@b843ebf9b913146b38da2eaa7aeddf76074ae1ad # v6
with:
distribution: 'temurin'
java-version: '21'
java-version: '25'

Check warning on line 47 in .github/workflows/test-integrations-tasks.yml

View check run for this annotation

@sentry/warden / warden: code-review

Java 25 can break Spark integration tests 

The Tasks workflow runs Spark integration environments with Java 25. The configured PySpark 3.5.9 and 4.2.0 environments do not override `JAVA_HOME`, while those Spark versions document support only through Java 17 and 21, respectively. This can prevent Spark from starting and fail the integration job. Keep Java 21 until these environments are verified on Java 25 or use a compatible JDK for them.

Check warning on line 47 in .github/workflows/test-integrations-tasks.yml

View check run for this annotation

@sentry/warden / warden: find-bugs

Java 25 may break Spark integration tests that require a supported JDK 

The Tasks workflow installs Java 25 for Spark integration tests. The PySpark 3.5.9 and 4.2.0 tox environments do not override `JAVA_HOME`, while their documented Java support ends at Java 17 and Java 21, respectively. Because the tests start a live `SparkContext`, these environments may fail to start Spark on Java 25. Keep Java 21 or use a compatible JDK for those environments unless Java 25 compatibility is verified.

@sentry-warden sentry-warden Bot Oct 19, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 25 can break Spark integration tests

The Tasks workflow runs Spark integration environments with Java 25. The configured PySpark 3.5.9 and 4.2.0 environments do not override JAVA_HOME, while those Spark versions document support only through Java 17 and 21, respectively. This can prevent Spark from starting and fail the integration job. Keep Java 21 until these environments are verified on Java 25 or use a compatible JDK for them.

Evidence
  • FRAMEWORKS_NEEDING_JAVA contains only spark, and test_group.jinja configures Java 21 for groups that need it; the generated Tasks workflow now configures Java 25.
  • tox.ini includes Spark environments for PySpark 3.5.9 and 4.2.0, but its Java 11 override applies only to Spark 3.0.3 and 3.5.6.
  • The Tasks workflow runs py${{ matrix.python-version }}-spark, so those Spark environments inherit the Java 25 installed by the workflow.

Identified by Warden · code-review · MFU-BC9

@cursor cursor Bot Oct 19, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Java 25 breaks Spark 3 tests

High Severity

Bumping java-version to 25 will fail the Spark 3.5.9 integration tests. pyspark 3.5.9 only supports Java 8, 11, and 17, and Spark 3.x still calls System.setSecurityManager, which JDK 24+ rejects. Those jobs create a SparkContext at fixture setup and will crash on startup. Spark 4.2.0 is unaffected, but 3.5.9 has no JAVA_HOME override.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit db98fbd. Configure here.

- name: Mark workspace safe for git (3.6/3.7 container)
# needed to make git rev-parse work in the containers
# subprocesses (e.g. sentry_sdk.utils.get_git_revision) can run git.
Expand Down
Loading